conda-incubator / conda-store

Data science environments, for collaboration. ✨
https://conda.store
BSD 3-Clause "New" or "Revised" License
139 stars 45 forks source link

Update conda-store explanations #726

Closed pavithraes closed 1 day ago

pavithraes commented 6 months ago

Addresses #748

Description

This pull request updates:

Pull request checklist

Additional information

This PR needs some more work, but is ready for an initial review.

netlify[bot] commented 6 months ago

Deploy Preview for conda-store ready!

Name Link
Latest commit 90a9bdd411252a4b4dd44921da7e49fc9d3dd168
Latest deploy log https://app.netlify.com/sites/conda-store/deploys/6699351d641c440008e94bd3
Deploy Preview https://deploy-preview-726--conda-store.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

peytondmurray commented 3 months ago

@pavithraes What's the status of this? Is there something I can do here to move this along? Those role permissions would be really nice to have.

pavithraes commented 3 months ago

@peytondmurray I'd appreciate a review on this PR if you have time, and any notes on the role mapping (I'm not familiar with the recent updates, so any notes will be helpful to complete that section). This PR is mainly blocked on an initial review.

peytondmurray commented 3 months ago

Here are the current role bindings:

    _viewer_permissions = {
        schema.Permissions.ENVIRONMENT_READ,
        schema.Permissions.NAMESPACE_READ,
        schema.Permissions.NAMESPACE_ROLE_MAPPING_READ,
    }
    _editor_permissions = {
        schema.Permissions.BUILD_CANCEL,
        schema.Permissions.ENVIRONMENT_CREATE,
        schema.Permissions.ENVIRONMENT_READ,
        schema.Permissions.ENVIRONMENT_UPDATE,
        schema.Permissions.ENVIRONMENT_SOLVE,
        schema.Permissions.NAMESPACE_READ,
        schema.Permissions.NAMESPACE_ROLE_MAPPING_READ,
        schema.Permissions.SETTING_READ,
    }
    _admin_permissions = {
        schema.Permissions.BUILD_DELETE,
        schema.Permissions.BUILD_CANCEL,
        schema.Permissions.ENVIRONMENT_CREATE,
        schema.Permissions.ENVIRONMENT_DELETE,
        schema.Permissions.ENVIRONMENT_READ,
        schema.Permissions.ENVIRONMENT_UPDATE,
        schema.Permissions.ENVIRONMENT_SOLVE,
        schema.Permissions.NAMESPACE_CREATE,
        schema.Permissions.NAMESPACE_DELETE,
        schema.Permissions.NAMESPACE_READ,
        schema.Permissions.NAMESPACE_UPDATE,
        schema.Permissions.NAMESPACE_ROLE_MAPPING_CREATE,
        schema.Permissions.NAMESPACE_ROLE_MAPPING_READ,
        schema.Permissions.NAMESPACE_ROLE_MAPPING_UPDATE,
        schema.Permissions.NAMESPACE_ROLE_MAPPING_DELETE,
        schema.Permissions.SETTING_READ,
        schema.Permissions.SETTING_UPDATE,
    }
pavithraes commented 1 month ago

@peytondmurray Thanks for a thorough review, I've addressed and incorporated all your comments. :)