conda-incubator / conda-store

Data science environments, for collaboration. ✨
https://conda.store
BSD 3-Clause "New" or "Revised" License
144 stars 46 forks source link

Fix issue when pip dependencies from poetry throw an error #736

Closed costrouc closed 8 months ago

costrouc commented 8 months ago

Fixes #735

Description

Prior to this PR create an environment that can't solve e.g.

name: test
channels:
 - conda-forge
dependencies:
 - python
 - pip
 - pip:
    - numpyyyyy

Pull request checklist

Additional information

netlify[bot] commented 8 months ago

Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
Latest commit 431e73a5b99464ccd94df053b564014617b95283
Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/65aa7b03a941130009147473
costrouc commented 8 months ago

@nkaretnikov I do think that we need to think through how to better catch these exceptions. Maybe just have a single catch-all and return a traceback in the logs. It feels like this could become "wack-a-mole" in the future if things change in the libraries that we depend on.