Closed nkaretnikov closed 7 months ago
Name | Link |
---|---|
Latest commit | 22848527a4c5fed9cc7091c870e17d089fbdc91d |
Latest deploy log | https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/65b584bee0269a0008f41490 |
@dcmcand PTAL. Note: I want to keep the diff minimal to make it easier to review, I'll rebase after this is approved.
Fixes #675.
Description
This pull request:
editor
fordeveloper
to role mappings, which is supported by the HTTP API and the DBThe auth flow is as follows:
editor
ordeveloper
)developer
)role_mappings
developer
from the DB is matched againsteditor
ordeveloper
inrole_mappings
(in this order).All user-visible parameters (the HTTP API and the
role_mappings
setting) allow for botheditor
anddeveloper
. The nameeditor
is preferred, which is reflected in the documentation. The namedeveloper
is supported for compatibility reasons.How I tested this locally:
role_mappings
are actually used by the test, I commented outeditor
in the defaultrole_mappings
developer
is still supported, I replacededitor
withdeveloper
in the defaultrole_mappings
editor
in the defaultrole_mappings
After making each of these changes in the application, I ran
and looked at the test output.
Pull request checklist
Additional information