conda-incubator / conda-store

Data science environments, for collaboration. ✨
https://conda.store
BSD 3-Clause "New" or "Revised" License
144 stars 46 forks source link

Add support for the `editor` role #738

Closed nkaretnikov closed 7 months ago

nkaretnikov commented 8 months ago

Fixes #675.

Description

This pull request:

The auth flow is as follows:

All user-visible parameters (the HTTP API and the role_mappings setting) allow for both editor and developer. The name editor is preferred, which is reflected in the documentation. The name developer is supported for compatibility reasons.

How I tested this locally:

After making each of these changes in the application, I ran

PYTEST_ADDOPTS="-rpfxs -k test_end_to_end_auth_flow" pytest tests

and looked at the test output.

Pull request checklist

Additional information

netlify[bot] commented 8 months ago

Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
Latest commit 22848527a4c5fed9cc7091c870e17d089fbdc91d
Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/65b584bee0269a0008f41490
nkaretnikov commented 8 months ago

@dcmcand PTAL. Note: I want to keep the diff minimal to make it easier to review, I'll rebase after this is approved.