Closed nkaretnikov closed 2 months ago
Name | Link |
---|---|
Latest commit | 806da5f0cba46bdef8e1dcb5edf10e34c2922fa1 |
Latest deploy log | https://app.netlify.com/sites/conda-store/deploys/66319c616dfacf0008a939a3 |
Deploy Preview | https://deploy-preview-777--conda-store.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@jaimergp PTAL. Keeping as a draft for now because this needs to be addressed first: https://github.com/conda-incubator/conda-store/pull/777#discussion_r1519165915. Will do final testing once that is resolved as well.
@jaimergp This is tested and ready for review, PTAL. Ignore the CI error, it's unrelated.
After the discussion in today's weekly:
Some background:
My asks:
build-id + timestamp + username
is ok. I do insist that this should just be an internal identifier in the database. The filesystem path could be computed later once input data is available.As things stand, this is a fixed-length implementation of v2
right? We could try a hashed-lockfile in a future v4.
@jaimergp and I had a 15 min call about this.
To get this merged:
$PREFIX/conda-meta/conda-store
file
<namespace>/<env>
-> hash
(if there're multiple generations, these should be stored in a sorted list by creation time)I talked with @trallard and we agree that we are good to merge, with the following reservations:
v3_experimental
) with no guarantees of hash stability across conda-store versions (for now).How does that sound? Thanks!
@jaimergp PTAL. Will rebase after this is approved.
Fixes #678.
Description
This pull request:
Pull request checklist
Additional information
How to test
Automated testing:
See tests changed in this PR.
Manual testing:
~/.conda-store
containing builds created on main, switch to this branch and create a new build: old and new builds should be accessible in the UI (lockfile, archive, and log links should work; marking one of the old builds as default should work)build_key_version = 3
in the configbuild_key_version = 2
in the config (make sure the previous default works with this PR)