conda-incubator / conda-store

Data science environments, for collaboration. ✨
https://conda.store
BSD 3-Clause "New" or "Revised" License
137 stars 44 forks source link

Support hash-only build paths #777

Closed nkaretnikov closed 2 months ago

nkaretnikov commented 3 months ago

Fixes #678.

Description

This pull request:

Pull request checklist

Additional information

How to test

Automated testing:

See tests changed in this PR.

Manual testing:

netlify[bot] commented 3 months ago

Deploy Preview for conda-store ready!

Name Link
Latest commit 806da5f0cba46bdef8e1dcb5edf10e34c2922fa1
Latest deploy log https://app.netlify.com/sites/conda-store/deploys/66319c616dfacf0008a939a3
Deploy Preview https://deploy-preview-777--conda-store.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nkaretnikov commented 3 months ago

@jaimergp PTAL. Keeping as a draft for now because this needs to be addressed first: https://github.com/conda-incubator/conda-store/pull/777#discussion_r1519165915. Will do final testing once that is resolved as well.

nkaretnikov commented 3 months ago

@jaimergp This is tested and ready for review, PTAL. Ignore the CI error, it's unrelated.

jaimergp commented 3 months ago

After the discussion in today's weekly:

Some background:

My asks:

As things stand, this is a fixed-length implementation of v2 right? We could try a hashed-lockfile in a future v4.

nkaretnikov commented 3 months ago

@jaimergp and I had a 15 min call about this.

To get this merged:

jaimergp commented 3 months ago

I talked with @trallard and we agree that we are good to merge, with the following reservations:

How does that sound? Thanks!

nkaretnikov commented 2 months ago

@jaimergp PTAL. Will rebase after this is approved.