Closed nkaretnikov closed 3 months ago
Name | Link |
---|---|
Latest commit | 03059d792e9f72036bd205a8764fa37ec5ab280d |
Latest deploy log | https://app.netlify.com/sites/conda-store/deploys/661036d97725510008c1a09f |
@jaimergp This is ready and tested, PTAL. CI failures are unrelated.
This looks good. Let's discuss the pinning item briefly and then we can make a decision.
@jaimergp Updated, PTAL.
The only concern I have is that the library version bounds might not be strict enough. The authors introduced a breaking change between 2.5.4 and 2.6.0. But this can also be updated later if we run into problems.
The only concern I have is that the library version bounds might not be strict enough. The authors introduced a breaking change between 2.5.4 and 2.6.0. But this can also be updated later if we run into problems.
Yea, I saw that, but hopefully they have learnt from that oversight. Also this kind of comment makes me believe they are being more careful now and not too keen on breaking anything else.
@jaimergp I've added platformdirs
to pyproject.toml
. I've never released conda-store, let's ask Tania.
@trallard How do new dependencies affect the release process? Anything to do besides updating pyproject.toml
and yaml files? I've read release.md
-- just making sure.
Only the pyprojecr.toml
needs updating
Fixes #648.
Description
This pull request:
CONDA_STORE_DIR
toplatformdirs.user_data_path
Pull request checklist
Additional information
How to test