conda-incubator / conda-store

Data science environments, for collaboration. ✨
https://conda.store
BSD 3-Clause "New" or "Revised" License
137 stars 44 forks source link

Package list in the admin UI should include pip packages #815

Open nkaretnikov opened 2 months ago

nkaretnikov commented 2 months ago

Context

Go to http://localhost:8080/conda-store/admin/build/<build_id>/. No pip packages are listed in "Conda Packages". Example spec:

channels:
- conda-forge
dependencies:
- python ==3.9
- pip:
  - flask
description: ''
name: test
prefix: null
variables: null

This is because conda-store-server/conda_store_server/server/templates/build.html only uses build.package_builds which doesn't contain pip packages:

{% if build.status.value in ['COMPLETED'] %}
...
        <h3 class="card-title">Conda Packages
            <span class="badge badge-light">{{ build.package_builds | length }}</span>
...
{% for package_build in build.package_builds %}
...
{% endif %}

Once pip packages are included, the list should be renamed to just "Packages".

Value and/or benefit

Admin UI is consistent with specification/lists all packages.

Anything else?

No response