search

conda-incubator / conda-store

Data science environments, for collaboration. ✨
https://conda.store
BSD 3-Clause "New" or "Revised" License
143 stars 46 forks source link

Build docker images for arm (aarch64) #822

Closed aktech closed 2 months ago

aktech commented 4 months ago

Fixes #821

Description

This pull request:

Pull request checklist

Additional information

How to test

netlify[bot] commented 4 months ago

Deploy Preview for conda-store canceled.

Name Link
Latest commit 70f2618d06e45a2921da3849b87d5d6441aaa03a
Latest deploy log https://app.netlify.com/sites/conda-store/deploys/66996cfe6bbbd60008082249
trallard commented 2 months ago

@aktech this has been in WIP for a bit. Are you planning to continue to work on this PR?

aktech commented 2 months ago

Yes. The windows test failure is unrelated: https://github.com/conda-incubator/conda-store/actions/runs/9006701345/job/25302259825?pr=822

and the docker image build got stalled, needs to be re-triggered.

The docker image built fine on my fork: https://github.com/aktech/conda-store/actions/runs/9003040226/job/24732748267

aktech commented 2 months ago

also, would need workflow trigger approval (potentially multiple times) to make it green

peytondmurray commented 2 months ago

Updated branch to trigger workflows, let's see if we can get this merged.

aktech commented 2 months ago

This is ready for review, CI is green now.

marcelovilla commented 2 months ago

@peytondmurray is there any reason not to approve this? I see you added the needs: discussion label.

peytondmurray commented 2 months ago

Nope, I'll merge it now - that label as added so I could easily filter for it during today's meeting.