conda-incubator / conda-store

Data science environments, for collaboration. āœØ
https://conda.store
BSD 3-Clause "New" or "Revised" License
149 stars 50 forks source link

DEV - Update conda-store build hook #872

Closed trallard closed 2 months ago

trallard commented 2 months ago

Description

Recent updates to conda-store-ui broke the already brittle build process of conda-store-server and conda-store-ui. This PR aims to make this more robust and remove some hacky bits we have relied on until now.

Note that the UI counterpart is at https://github.com/conda-incubator/conda-store-ui/pull/418 so both PRs must be merged for the build and release to work.

Pull request checklist

Additional information

This PR not only improves our build process but makes it so that one can build conda-store-server with a local copy repo/copy of conda-store-ui (vs only a released version). To test these two PRs together:

  1. Check out https://github.com/conda-incubator/conda-store-ui/pull/418 in your local clone of conda-store-ui
  2. Bundle the package as if for a release with run webpack:prod bundle
  3. Check out this PR on your local clone of conda-store and cd to conda-store-server
  4. Build conda-store-server with your local copy of conda-store-ui with export LOCAL_UI=<full path to the root the conda-store-ui repo> && hatch build --clean
  5. Run conda-store-server in standalone mode:
# quick way to verify the build
conda-store-server --standalone

You should see the dev version of the UI

image

netlify[bot] commented 2 months ago

Deploy Preview for conda-store ready!

Name Link
Latest commit 3f514525407818fe9021b79441cdcb8a99569741
Latest deploy log https://app.netlify.com/sites/conda-store/deploys/66e1b9aa5768ad00082a9fa8
Deploy Preview https://deploy-preview-872--conda-store.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.