conda-incubator / conda-store

Data science environments, for collaboration. ✨
https://conda.store
BSD 3-Clause "New" or "Revised" License
149 stars 50 forks source link

REACT_APP_URL_BASENAME #898

Closed gabalafou closed 1 month ago

gabalafou commented 1 month ago

Description

Companion PR to https://github.com/conda-incubator/conda-store-ui/pull/431

Pull request checklist

netlify[bot] commented 1 month ago

Deploy Preview for conda-store canceled.

Name Link
Latest commit 3e8398e3ad7be91522399aed1a3835f1661aa6cf
Latest deploy log https://app.netlify.com/sites/conda-store/deploys/67126d3ef18252000874bfe2
gabalafou commented 1 month ago

I realized while working on this that we need to have a strategy for how to handle what happens when a user goes directly to a React app-defined route, such as: "/default/new-environment".

Currently, the server will return a 404 instead of returning the conda-store-ui.html page.

I don't know all the ins and outs of the server, but we should probably redirect all unknown routes to the React app.

gabalafou commented 1 month ago

Created an issue: