search

conda-incubator / conda-store

Data science environments, for collaboration. ✨
https://conda.store
BSD 3-Clause "New" or "Revised" License
149 stars 50 forks source link

Move seeding tests functionality into test module #925

Closed soapy1 closed 3 weeks ago

soapy1 commented 3 weeks ago

partially addresses https://github.com/conda-incubator/conda-store/issues/914

Description

This PR moves a module that is used to seed the db for testing from inside the app module to the testing module. This also allows for the removal of the tests that test this seeding

Pull request checklist

netlify[bot] commented 3 weeks ago

Deploy Preview for conda-store canceled.

Name Link
Latest commit eb0c5b601100efb601f4a307270a2007b0f6af12
Latest deploy log https://app.netlify.com/sites/conda-store/deploys/671c1ce136b5430008d2b392
netlify[bot] commented 3 weeks ago

Deploy Preview for conda-store canceled.

Name Link
Latest commit 34e2fae8a06f457df18eeb2e978a529315270a90
Latest deploy log https://app.netlify.com/sites/conda-store/deploys/671c1cec6dc908000814d91a
soapy1 commented 3 weeks ago

This seemed like a little bit of a strange pattern to me. I'm not sure if this is a common pattern in python apps, happy to close this PR if it is. Otherwise, cleaning it up while working through speeding up tests.

peytondmurray commented 3 weeks ago

I certainly prefer this organization; these functions are exclusively used for building fixtures, which belong in conftest.py. I'm happy to merge this.