conda-incubator / conda-zsh-completion

zsh completion for conda
Do What The F*ck You Want To Public License
364 stars 65 forks source link

Set initial value outside of local. Fixes #42 #46

Closed hwalinga closed 6 months ago

hwalinga commented 1 year ago

Old version of zsh cannot set initial value when declaring with local. Giving you all environment variables as a side effect. This change fixes that bug. This bug appears on zsh 5.0.2, as seen on CentOS 7, as previously reported.

Fixes #42

NB. My vim fixed some extra white space automatically. Hope you don't mind.

esc commented 1 year ago

@jezdez can you look into reviewing this one?

coldfix commented 10 months ago

I've encountered the same issue on RHEL7 (zsh 5.0.2). Without this fix, the terminal is flodded with gobbledygook after conda activate + <tab>

esc commented 6 months ago

I'm going to merge this speculatively based on user input, we can always revert or find an alternative if this breaks the completion for everyone else (which I highly doubt).

Thank you @hwalinga and @coldfix