conda-incubator / setup-miniconda

Set up your GitHub Actions workflow with conda via miniconda
https://github.com/marketplace/actions/setup-miniconda
MIT License
407 stars 69 forks source link

Split lint into check and build, switch from `npm install` to `npm ci` #315

Closed dbast closed 11 months ago

dbast commented 11 months ago

This splits the lint flow into two jobs:

This information was previously not visible / masked as mostly npm run check failed and prevented npm run build from running ... it was then unclear, if that has consequences to the ncc compiled stuff in ./dist or not.

Also switching npm install to npm ci to install the exact versions from package-lock.json (managed by dependabot). This is faster, more secure and 100% predictable. Thus removing the cron triggers as those won't find anything new.

dbast commented 11 months ago

yay... lint and build each only take 14 sec.

goanpeca commented 11 months ago

Awesome, thanks for working on this 🚀