search

conda-tools / conda-build-all

BSD 3-Clause "New" or "Revised" License
30 stars 24 forks source link

Release 1.0 #60

Closed pelson closed 7 years ago

pelson commented 8 years ago

As a heads up, the next release of conda-build-all will support conda-build 2.0, and it will be released as version 1.0.

ericdill commented 8 years ago

This issue can be closed. conda-build-all 1.0 is released

mwcraig commented 8 years ago

fyi, looks like https://github.com/SciTools/conda-build-all/pull/63 means conda-build-all is only compatible with conda-build >=2. Maybe update the requirements? Will do a little more testing to confirm that this is the case.

mwcraig commented 8 years ago

I think the issue is with this line, because conda build 1.x only had one requirement for bldpkg_path: https://github.com/SciTools/conda-build-all/blob/master/conda_build_all/build.py#L42

I think a perfectly fine solution is to bump the conda build requirement, but if you want compatibility with conda build 1.x the fix should be pretty simple.

pelson commented 8 years ago

Ideally we would have compatibility with v1.x for a few releases to ease the pressure on people (e.g. conda-forge) updating.

jakirkham commented 7 years ago

So I thought we did add a compatibility layer for v1.x as we are using it in staged-recipes. In any event, should this be closed as everything here appears to be done.

mwcraig commented 7 years ago

Should I open a separate issue for the compatibility issues with conda build 1.x? There are several, despite several try/except clauses and if/thens that appear to be trying to deal with the issue.

This line does not work with conda-build 1, as explained here.

conda_build.api is called directly in one place even though there is no such module in conda build 1.x:

https://github.com/SciTools/conda-build-all/blob/master/conda_build_all/build.py#L42

PR incoming in a few minutes to fix those...

jakirkham commented 7 years ago

If you are submitting a PR to fix these already, I wouldn't bother with a separate issue I don't think. Though if it would take longer, yes I think it should be. Mainly because I think this topic is getting lost in an issue about a release that has already happened.

mwcraig commented 7 years ago

PR opened, close away!

jakirkham commented 7 years ago

I'm guessing we have solved all conda-build 1.x/2.x issues or at least all we care to as we have been using 2.x for some time. So am closing this as resolved. However if there are unsettled issues, please feel free to reopen.