search

conda-tools / conda-build-all

BSD 3-Clause "New" or "Revised" License
30 stars 24 forks source link

Fix a couple compatibility issues with conda build 1.x #68

Closed mwcraig closed 7 years ago

mwcraig commented 7 years ago

As discussed in #60, there were a couple of lines that are not compatible with conda build 1.x. This should fix those...

ocefpaf commented 7 years ago

Thanks @mwcraig for the PR and @pelson for merging.

BTW this is no longer a conda-build 1 workaround because this behavior is back in latest conda-build 2. So the previous behavior, that used the extra config argument, is the one deprecated.

PS: Can we get a new release :wink:

mwcraig commented 7 years ago

@Ocepaf - I think the change needed for t latest conda-build is a little different than that. The call being made now is not part of t API and should not be used. There is an API now for getting the path to the built package. Will get to that PR on Monday unless someone else does it sooner.

ocefpaf commented 7 years ago

There is an API now for getting the path to the built package.

Nice. I thought there was not one when I tried #70

mwcraig commented 7 years ago

See this if you want to fix today :wink:: https://github.com/astropy/conda-channel-astropy/issues/105#issuecomment-265346930

I'd wait for that fix before a new release that we know will be broken with the latest conda build.

ocefpaf commented 7 years ago

Thanks @mwcraig. I can wait. (I had it pinned before to get the packages uploaded but now I actually want the get latest conda-build in my repo.)

Cool! did not know about get_output_file_path.

mwcraig commented 7 years ago

Neither did I...still not used to the idea that there is an API that should be used instead of reading the source code!

jakirkham commented 7 years ago

So this seems to cause some weird issues when trying to build things using numpy. Not entirely sure why, but going back to 1.0.0 does not encounter these issues.

xref: https://github.com/SciTools/conda-build-all/issues/75