search

conda-tools / conda-build-all

BSD 3-Clause "New" or "Revised" License
30 stars 24 forks source link

Remove the config arg in bldpkg_path #70

Closed ocefpaf closed 7 years ago

ocefpaf commented 7 years ago

bldpkg_path does not need the config argument in latest conda-build.

This causes conda-build-all to fail when trying to upload a package.

Using Anaconda API: https://api.anaconda.org
Uploading folium to the main channel.
INFO artefact_destination:make_available(116): Uploading folium to the main channel.
Traceback (most recent call last):
  File "/opt/conda/bin/conda-build-all", line 11, in <module>
    load_entry_point('conda-build-all==1.0.0', 'console_scripts', 'conda-build-all')()
  File "/opt/conda/lib/python3.5/site-packages/conda_build_all/cli.py", line 90, in main
    b.main()
  File "/opt/conda/lib/python3.5/site-packages/conda_build_all/builder.py", line 265, in main
    config=build_config)
  File "/opt/conda/lib/python3.5/site-packages/conda_build_all/builder.py", line 285, in post_build
    config=config)
  File "/opt/conda/lib/python3.5/site-packages/conda_build_all/artefact_destination.py", line 118, in make_available
    config=config)
  File "/opt/conda/lib/python3.5/site-packages/conda_build_all/build.py", line 42, in upload
    fname = bldpkg_path(meta, config)
TypeError: bldpkg_path() takes 1 positional argument but 2 were given
ocefpaf commented 7 years ago

Not sure if the failures are related to the changes here. Note that https://github.com/SciTools/conda-build-all/pull/68 probably fixes this too, but in our last call I remember @msarahan mentioning that we should avoid using bldpkg_path.

@pelson can you take a look at this? It is preventing us from uploading packages with latest conda-build.

pelson commented 7 years ago

@ocefpaf - I went ahead and merged #68, but am not against ceasing using bldpkg_path if it is deprecated. @msarahan - would you mind making the call as to the preferred direction? I'm basically looking for a steer to either either merge or close this PR...

ocefpaf commented 7 years ago

Phil I am happy with #68. I sent this more to draw your attention to the problem and provide an alternative than anything ;-)

On Fri, Dec 16, 2016 at 4:15 AM, Phil Elson notifications@github.com wrote:

@ocefpaf https://github.com/ocefpaf - I went ahead and merged #68 https://github.com/SciTools/conda-build-all/pull/68, but am not against ceasing using bldpkg_path if it is deprecated. @msarahan https://github.com/msarahan - would you mind making the call as to the preferred direction? I'm basically looking for a steer to either either merge or close this PR...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SciTools/conda-build-all/pull/70#issuecomment-267532482, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6BLxF_SRb5pb0IUICa5A42P6-s22GSks5rIjqrgaJpZM4LNZBd .

pelson commented 7 years ago

👍