search

conda / ceps

Conda Enhancement Proposals
Creative Commons Zero v1.0 Universal
20 stars 24 forks source link

CEP: Recipe serialization in packages #74

Open wolfv opened 7 months ago

wolfv commented 7 months ago

Rendered version: ✏️ https://github.com/wolfv/ceps/blob/cep-recipe-serialization/cep-recipe-serialization.md

dholth commented 6 months ago

Why not .json? Do we still need info/recipe/meta.yaml ?

wolfv commented 4 months ago

I changed this CEP a little - most of the CEP is now "implementation specific" and serves as documentation of what rattler-build does.

However, the CEP does require alternative build tools to implement a rendered recipe, and also requires a new file to be added to the package (info/used_build_tool.json).

jezdez commented 4 months ago

@conda/steering-council

This vote falls under the "Enhancement Proposal Approval" policy of the conda governance policy, please vote and/or comment on this proposal at your earliest convenience.

It needs 60% of the Steering Council to vote yes to pass.

To vote, please leave yes, no or abstain as comments below.

If you have questions concerning the proposal, you may also leave a comment or code review.

This vote will end on 2024-07-16, End of Day, Anywhere on Earth (AoE). This is an extended voting period due to summer holiday time in the Northern Hemisphere.

baszalmstra commented 4 months ago

yes

wolfv commented 4 months ago

Please use the following form to vote:

@xhochy (Uwe Korn)

@cj-wright (Christopher J. 'CJ' Wright)

@mariusvniekerk (Marius van Niekerk)

@goanpeca (Gonzalo Peña-Castellanos)

@chenghlee (Cheng H. Lee)

@ocefpaf (Filipe Fernandes)

@marcelotrevisani (Marcelo Duarte Trevisani)

@msarahan (Michael Sarahan)

@mbargull (Marcel Bargull)

@jakirkham (John Kirkham)

@jezdez (Jannis Leidel)

@wolfv (Wolf Vollprecht)

@jaimergp (Jaime Rodríguez-Guerra)

@kkraus14 (Keith Kraus)

@baszalmstra (Bas Zalmstra)

wolfv commented 4 months ago

@marcelotrevisani @jakirkham @cj-wright @mbargull last chance to vote!

chenghlee commented 4 months ago

For the record: voted "no" because while I like the ideas presented in this CEP, I don't think the CEP as written is ready to be adopted as a specification. IMO, various unanswered questions/comments need to be addressed before adoption, and we should better separate behavioral specifications from implementation details.

mbargull commented 4 months ago

I think it is good to have these parts of the build output/process specified which is why I support to have a proposal for it here. I do agree with Cheng in that this is not yet ready to be put in, though, since the "Specification" section is a bit light in detail and the bigger part of the text, i.e., description of implementation details, are likely to change, so nothing we'd set in stone here.

mbargull commented 4 months ago

(tried to use the checkbox, but had issues with it for some reason)

@jakirkham It's really odd that it doesn't like to accept your edit :/. I checked "yes" on your behalf.

jakirkham commented 4 months ago

Thanks Marcel! 🙏

Yeah this happened to me a couple times. So just used "approved" to mean the same thing. Think it is because I tried on my iPhone with GitHub Mobile (not sure why it can't check a box or why it makes an empty edit though 🤷‍♂️)

wolfv commented 3 months ago

The vote is closed, and we have the following result:

Total voters: 15 (valid: 13 = 86.67%)

Yes votes (11 / 84.62%):

No votes (2 / 15.38%)):

Abstain votes (0 / 0.00%):

Not voted (2):

Invalid votes (0):

Thus we reached quorum and enough YES votes to mark this as accepted. 🎉