Closed 183amir closed 7 years ago
Ok I found what is wrong. The SUBDIR
environment variable set here: https://github.com/conda/conda-build/blob/master/conda_build/environ.py#L243 affects the behavior of make.
To fix it I am unsetting SUBDIR
in the build.sh
file:
SUBDIR_BAK=$SUBDIR
unset SUBDIR
./configure \
--prefix="${PREFIX}" \
--disable-doc \
--enable-shared \
--enable-static \
--extra-cflags="-Wall -g -m64 -pipe -O3 -march=x86-64 -fPIC `pkg-config --cflags zlib`" \
--extra-cxxflags=="-Wall -g -m64 -pipe -O3 -march=x86-64 -fPIC" \
--extra-libs="`pkg-config --libs zlib`" \
--enable-pic \
--enable-gpl \
--enable-libx264
make
make install
export SUBDIR=$SUBDIR_BAK
Is that ok? or is it going to change conda build's behavior? What would be the proper solution here? If this SUBDIR
variable is used internally, isn't better to rename it to something more specific?
Unsetting that is totally fine. It will only affect what happens in that shell script. Strange that they depend on that environment variable, but I think it's just an unfortunate coincidence.
I don't recall what subdir is used for in build.sh, if anything. We might be able to remove it as an environment variable.
It would be best if it was removed as an environment variable.
That or rename it. Looks like this was for the benefit of build scripts, right?
Edit: How about CONDA_SUBDIR
or similar?
Hi there, thank you for your contribution!
This issue has been automatically locked because it has not had recent activity after being closed.
Please open a new issue if needed.
Thanks!
FFmpeg was being compiled with
conda-build 1.20.3
before but it is not compiling with the newer versions anymore. I tried several different versions and none of them work after that release. I have no idea what is going wrong here.The recipe of ffmpeg is from https://github.com/conda-forge/ffmpeg-feedstock
This issue is also reported here: https://github.com/conda-forge/ffmpeg-feedstock/issues/12