search

conda / conda-build

Commands and tools for building conda packages
https://docs.conda.io/projects/conda-build/
Other
383 stars 423 forks source link

find used variables doesn't consider short-circuiting #3255

Open isuruf opened 5 years ago

isuruf commented 5 years ago

Actual Behavior

If I have # [osx and c_compiler == 'toolchain_c'], then conda-build thinks c_compiler is used in windows as well.

Expected Behavior

c_compiler not in used variables in windows.

Steps to Reproduce

example recipe: https://github.com/conda-forge/r-base-feedstock/pull/61

Using conda-build 3.16.2

msarahan commented 5 years ago

Known issue. Conda build would have to parse, not just pattern match. It would be a large increase in complexity. PRs definitely welcome here if you have good ideas on how to do this without too much work. It would be a big improvement, but it's not one that we have time to do ourselves right now.

github-actions[bot] commented 1 year ago

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    • What OS and version you reproduced the issue on
    • What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

jakirkham commented 1 year ago

Let's keep this open