search

conda / conda-build

Commands and tools for building conda packages
https://docs.conda.io/projects/conda-build/
Other
380 stars 421 forks source link

Remove broken `$CONDA_DEFAULT_ENV` templating engine #5494

Open kenodegard opened 4 days ago

kenodegard commented 4 days ago

Checklist

What is the idea?

Originally added in https://github.com/conda/conda-build/pull/578 (see writeup in https://github.com/conda/conda-build/pull/575) this templating engine would appear to be a precursor to the conda_build_config.yaml used today.

This templating engine is an odd artifact at this point and actually wont work anymore unless there happens to be a directory in the user's CWD that matches the currently active environment.

Per searches here on GitHub conda-forge, bioconda, nor Anaconda uses this templating engine anymore.

Uncovered while investigating #5493

Why is this needed?

Less legacy code to wrangle.

What should happen?

Review and remove clearly outdated code from the Jinja templating engine.

Additional Context

No response

kenodegard commented 4 days ago

The code block referenced:

https://github.com/conda/conda-build/blob/433f0482c8217001a28ceb6a5d3ee778ccea288f/conda_build/metadata.py#L1945-L1953

kenodegard commented 4 days ago

Later on CONDA_DEFAULT_ENV is also set as the host_prefix within the templating engine:

https://github.com/conda/conda-build/blob/433f0482c8217001a28ceb6a5d3ee778ccea288f/conda_build/environ.py#L392