search

conda / conda-libmamba-solver

The libmamba based solver for conda.
https://conda.github.io/conda-libmamba-solver/
Other
199 stars 24 forks source link

.solv files not being reused #481

Closed tl-hbk closed 2 months ago

tl-hbk commented 3 months ago

Checklist

What happened?

It looks like in the following commit https://github.com/conda/conda-libmamba-solver/commit/8d9d6c03fd13e6a86a16fc396e1f7413baa269ea

a try_solv argument was added to _json_path_to_repo_info which defaults to False.

From what I can tell this was added so that reload_local_channels could invalidate the .solv files but only other call to _json_path_to_repo_info in _load_channels did not get updated to use try_solv=True.

This is causing every solve attempt to parse the repodata json and regenerate the .solv files even when all the channels are cache hits. This leads to a performance hit.

Conda Info

No response

Conda Config

No response

Conda list

No response

Additional Context

No response

jaimergp commented 3 months ago

Oh, excellent catch and just in time for a release, I'd say.