Fix conda-build compatibility regression - Githubissues

conda / conda-libmamba-solver

The libmamba based solver for conda.

https://conda.github.io/conda-libmamba-solver/

Other

204 stars 25 forks source link

Fix conda-build compatibility regression #531

Closed jaimergp closed 2 months ago

jaimergp commented 2 months ago

Description

https://github.com/conda/conda-libmamba-solver/pull/449 introduced a regression (identified in https://github.com/conda-forge/rust-feedstock/pull/210) caused by two different bugs in conda.model.channel.Channel: https://github.com/conda/conda/issues/14259 and https://github.com/conda/conda/issues/14258.

It's a kind of a perfect storm situation:

Requires multi-output recipe with first output being noarch and second output being OS-specific
Deduplication is based on __eq__ which in Channel deliberately ignores the subdir.
We were passing subdirs explicitly but this is silently ignored in Channel.urls() if Channel.platform is defined.

The fix is to remove Channel.platform attributes to let the explicit subdirs take over and then we can deduplicate safely.

Checklist - did you ...

[x] Add a file to the news directory (using the template) for the next release's release notes?
[ ] Add / update necessary tests?
[ ] Add / update outdated documentation?