search

conda / conda-lock

Lightweight lockfile for conda environments
https://conda.github.io/conda-lock/
Other
492 stars 103 forks source link

Add filelock as a dependency #313

Closed mariusvniekerk closed 1 year ago

mariusvniekerk commented 1 year ago

This seems to be needed for some classes of pip based resolution

netlify[bot] commented 1 year ago

Deploy Preview for conda-lock ready!

Name Link
Latest commit 3ff3a0a82b82a6edd25af4a9c14e9ee66d28a0dc
Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/63c0368d9b01de000ab1e1fe
Deploy Preview https://deploy-preview-313--conda-lock.netlify.app/src_pyproject
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

maresb commented 1 year ago

As of four months ago, filelock >=3.8.0 should already be implicit in cachecontrol[filecache]. But explicit is better than implicit.

I'm concerned about removing the pip-support option and breaking pipelines, but a quick experiment shows that pip only emits a warning, so I think we're good.

maresb commented 1 year ago

Closes #299