conda / conda-lock

Lightweight lockfile for conda environments
https://conda.github.io/conda-lock/
Other
470 stars 102 forks source link

Apply auth also for private pypi packages #323

Closed croth1 closed 1 year ago

croth1 commented 1 year ago

previous logic converted all lock files to explicit type and ignored all lines starting with #or @. This however does not allow adding auth to packages from private pypi indices, as they are represented as # pip package @ index_url and thus were skipped in the auth re-adding logic.

netlify[bot] commented 1 year ago

Deploy Preview for conda-lock ready!

Name Link
Latest commit 801110f98a82450098d226570c7d6b5693fd2ede
Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/63d6d483ab5f5c0009afac5c
Deploy Preview https://deploy-preview-323--conda-lock.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

croth1 commented 1 year ago

@maresb whom do I need to bribe to get this reviewed? :)

maresb commented 1 year ago

Hi @croth1! I don't have much time these days, but at least this one is nice and short!

You could start by bribing me with a test case so that we can prevent regressions. :slightly_smiling_face: Thanks!

croth1 commented 1 year ago

@maresb, I integrated the new logic into existing test cases - strictly speaking the auth stripping logic does not seem to be needed for pypi, as the current poetry code does that automatically. However this way the pypi auth logic is the same as the conda auth logic and was a bit easier to integrate into the tests. Hope that's fine with you.

netlify[bot] commented 1 year ago

Deploy Preview for conda-lock ready!

Name Link
Latest commit 0e7bd6725c1be38266f48c994ef58fde8e3b446e
Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/63ee998ca352a1000868de96
Deploy Preview https://deploy-preview-323--conda-lock.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

maresb commented 1 year ago

Thanks so much @croth1!!!