search

conda / conda-lock

Lightweight lockfile for conda environments
https://conda.github.io/conda-lock/
Other
470 stars 102 forks source link

Remove all References of `pip_support` Flag #340

Closed srilman closed 1 year ago

srilman commented 1 year ago

Description

Closes #339 by removing any references of the pip_support extra from the docs and README. It also removes the vacuous use of the PIP_SUPPORT flag and anywhere that flag is passed into, especially in the conda_lock.src_parser.environment_yaml.py module.

netlify[bot] commented 1 year ago

Deploy Preview for conda-lock ready!

Name Link
Latest commit 0b54d6229047427d77aef57e0488bdfeabd245f7
Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/63e618031a6f1a000810437e
Deploy Preview https://deploy-preview-340--conda-lock.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

srilman commented 1 year ago

I'm seeing test cases that use Docker Quetz error out at the setup stage:

ERROR at setup of test_private_lock[conda-$QUETZ_API_KEY]
...

I don't see anything in conftest.py that indicates that this PR was the cause of the issue, so I will rerun CI in ~1 hour or so.

srilman commented 1 year ago

I just restarted the failing tests.

Thanks @maresb!

srilman commented 1 year ago

Hmm, I'm still seeing the Quetz tests erroring out in the pytest fixture quetz_server

maresb commented 1 year ago

Regarding Quetz failures see https://github.com/conda/conda-lock/issues/338. I think we just keep retrying for now. :slightly_frowning_face:

maresb commented 1 year ago

Thanks @srilman!!!