Have Vendored Poetry Store Config, Cache, and Data Folders in "pypoetry-conda-lock"

srilman commented 1 year ago

Description

We determined that the problems we noticed in #315 was caused when Poetry is installed on a user's machine and it's cache conflicts with the vendored poetry's cache. By modifying the locations inside of vendored poetry, we can ensure that it

Stores it cache, config files, and data folder in a different folder from poetry. Poetry stores them in a folder called "pypoetry" and we will in "pypoetry-conda-lock". Note that the location of the folder is OS specific. More details can be found here: https://python-poetry.org/docs/configuration/#default-directories
Ensure that vendored poetry will not use any config options a user sets for regular poetry

Note that as @maresb suggested in https://github.com/conda/conda-lock/issues/315#issuecomment-1418361666, I added a option to vendoring in pyproject.toml to replace any instances of "pypoetry", but manually modified the affected file myself since re-vendoring Poetry is not possible right now.

netlify[bot] commented 1 year ago

Deploy Preview for conda-lock ready!

Name	Link
Latest commit	36a2c95f5c6fc8d274a9169f3b2259fad9dc4812
Latest deploy log	https://app.netlify.com/sites/conda-lock/deploys/63e63448bf5f9c0008f8cc30
Deploy Preview	https://deploy-preview-342--conda-lock.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

maresb commented 1 year ago

In preparation to merge I removed the debug commit and rebased on main.

maresb commented 1 year ago

I will be entirely AFK a while, but I would have liked to merge as soon as this turns green. Perhaps we should enable GH automerge in this repo.

srilman commented 1 year ago

Why not allow the PR creator to merge their PR when ready? We can set GitHub up to only allow Merges (not Squash or Rebase) and to only enable it once all checks are passing.

maresb commented 1 year ago

Thanks a lot @srilman for all your help!!!

Why not allow the PR creator to merge their PR when ready? We can set GitHub up to only allow Merges (not Squash or Rebase) and to only enable it once all checks are passing.

Do you know the specific settings we'd need to change to set this up?

conda / conda-lock