search

conda / conda-lock

Lightweight lockfile for conda environments
https://conda.github.io/conda-lock/
Other
470 stars 102 forks source link

Invoke codecov only in CI #352

Closed maresb closed 1 year ago

maresb commented 1 year ago

Closes #351

netlify[bot] commented 1 year ago

Deploy Preview for conda-lock ready!

Name Link
Latest commit f4313731519641e1b0e2b7aea89927504d960844
Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/63eca684a8783c000964abae
Deploy Preview https://deploy-preview-352--conda-lock.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

maresb commented 1 year ago

Hi @dbast, could you please take a look at issue #351 when you get the chance? For some reason, codecov seems to break interactive debugging in VS Code and more. Have you run into this before? Does this PR look like a sensible fix, or do you have another suggestion? Thanks!!!

dbast commented 1 year ago

Makes sense to be... a pity, but seems to be the best option to do it like that... there is also https://github.com/microsoft/vscode-python/issues/693#issuecomment-1356832568 but that requires configuration on dev side.

maresb commented 1 year ago

Ya, I thought about that comment, but it seems to me like it's VS Code specific solution, while the issue affects other IDEs as well.

Thanks a lot for the quick approval! I'll merge soon, but I'm happy to revisit this if another solution emerges.