conda / conda-lock

Lightweight lockfile for conda environments
https://conda.github.io/conda-lock/
Other
467 stars 102 forks source link

Handle Poetry Optional Dependency Quirks #388

Closed srilman closed 1 year ago

srilman commented 1 year ago

Fixes #385. This is a compilation of some unusual behavior I noticed when conda-lock parses some dependencies in pyproject.toml files with conflicting attributes:

There are all things that Poetry seems to handle quietly in its own way (see the related issue). To minimize the number of parsing changes, I did not change how conda-lock treats the resulting categories of dependencies.

Essentially, this PR ensures that we maintain the invariant that an optional source dependency is a dependency not part of the main category. This is important for future PRs implementing multiple category support.

netlify[bot] commented 1 year ago

Deploy Preview for conda-lock ready!

Name Link
Latest commit 4840892c3fbc4c96be26c2350505d4540efeac12
Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/640e6dc6c58f490008ac9237
Deploy Preview https://deploy-preview-388--conda-lock.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

maresb commented 1 year ago

I'm really looking forward to this PR series, but unfortunately I have no time this week.

srilman commented 1 year ago

No worries @maresb. Always appreciate your reviews!