Closed romain-intel closed 1 year ago
Name | Link |
---|---|
Latest commit | 7e0650fffcb5f047bc605e3ff05ba5fb4172cfec |
Latest deploy log | https://app.netlify.com/sites/conda-lock/deploys/6478cdc18ca9fa00087df7c5 |
Deploy Preview | https://deploy-preview-425--conda-lock.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Thanks a lot for this @romain-intel!
It looks like we're starting to manipulate structured data as strings, which tends to eventually lead to issues. I wonder if it would instead make more sense here to lean on conda_spec_to_versioned_dep.
I personally don't understand the design decision of making [tool.conda-lock.dependencies]
a dict instead of a list. (It feels like Poetry-motivated insanity.) Consequently, instead of a nice MatchSpec
string we now have this awkward depname
depattrs
key-value-pair. Optimistically, perhaps conda_spec_to_versioned_dep(f"{depname} {depattrs}", "main")
might work?
That's probably a better solution and more in line with what the environment.yaml does. I can make that change and try it out.
There we go -- looks even better. Tiny change :)
Woah, I can't believe that actually worked! :joy: Nicely done!
This functionality worked for environment.yml type of files but was broken for TOML files.
Description
Small change to allow the use of
channel::package
in thetool.conda-lock.dependencies
section of TOML files.A test is included. The test fails before this PR and succeeds after. The test specifically includes a package that is available on the channel specified but not on the default conda-forge channel.