search

conda / conda-lock

Lightweight lockfile for conda environments
https://conda.github.io/conda-lock/
Other
459 stars 102 forks source link

Create macOS platform tags using packaging #439

Closed jjhelmus closed 1 year ago

jjhelmus commented 1 year ago

Description

Populate the list of supported platforms tags for the macOS platform using the mac_platforms function in packaging.tags. This given a complete listing of platform tags which is also used by pip.

This avoiding the need to periodically update a static listing of tags. The new MACOS_VERSION variable will need to be updated periodically to reflect the latest version of macOS.

Likely fixes #403 and #436

netlify[bot] commented 1 year ago

Deploy Preview for conda-lock ready!

Name Link
Latest commit e6acc979b54d1c7de3a9724a223916578aba1ffe
Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/649c51356caa100008d4ccc7
Deploy Preview https://deploy-preview-439--conda-lock.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

maresb commented 1 year ago

Thanks a lot for this @jjhelmus! This looks more promising than the ad-hoc suggestion in #403.

I am wondering how we should test this. Probably by adding #403 and #436 as test cases, if they are reproducible and are indeed closed by this.