Tests in ubunut/macos GHA jobs fail silently - Githubissues

conda / conda-lock

Lightweight lockfile for conda environments

https://conda.github.io/conda-lock/

Other

459 stars 102 forks source link

Tests in ubunut/macos GHA jobs fail silently #447

Closed riccardoporreca closed 1 year ago

riccardoporreca commented 1 year ago

Checklist

[X] I added a descriptive title
[X] I searched open reports and couldn't find a duplicate

What happened?

I noticed that failed tests in the GitHub Actions workflows for ubuntu and macos do not casue the step/job to fail, see e.g.

https://github.com/conda/conda-lock/actions/runs/5466015810/jobs/9950322426#step:6:1001

 = 6 failed, 108 passed, 24 skipped, 4 xfailed, 12 warnings in 826.36s (0:13:46) =

Conda Info

Irrelevant

Conda Config

Irrelevant

Conda list

Irrelevant

Additional Context

This can be easily controlled for bash tasks, see https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference

riccardoporreca commented 1 year ago

I have been a bit proactive and proposed a fix in #448