Protect against unordered extras in pip dependencies

conda / conda-lock

Lightweight lockfile for conda environments

https://conda.github.io/conda-lock/

Other

459 stars 102 forks source link

Closed AlbertDeFusco closed 1 year ago

AlbertDeFusco commented 1 year ago

By sorting the extras in VersionedDependency this should help addresses hash instability as mentioned in #449.

netlify[bot] commented 1 year ago

Name	Link
Latest commit	682bce3f9098dede2df55de6f34c5ca4e518f658
Latest deploy log	https://app.netlify.com/sites/conda-lock/deploys/64a89268da277e0008317128
Deploy Preview	https://deploy-preview-450--conda-lock.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

maresb commented 1 year ago

Very nice!!! Thanks for this.

One very minor suggestion: I think this test would fit better under the newly created test_regression.py file.

AlbertDeFusco commented 1 year ago

Ok, I'll make the change

maresb commented 1 year ago

Sorry about the failing Windows test. Attempted fix in #451, and feel free to ignore those failures.

AlbertDeFusco commented 1 year ago

Done. I think this is ready

maresb commented 1 year ago

Thanks @AlbertDeFusco!!!