search

conda / conda-lock

Lightweight lockfile for conda environments
https://conda.github.io/conda-lock/
Other
459 stars 102 forks source link

Fix virtual package versions being detected as floats #451

Closed maresb closed 1 year ago

maresb commented 1 year ago

Description

Looks like either Pydantic 2 parsing is breaking something or a failing test may have gotten merged.

This fixes it by quoting the X.Y-style version strings

netlify[bot] commented 1 year ago

Deploy Preview for conda-lock ready!

Name Link
Latest commit 7dd1e5f121ccd301b36e8992b370751e83bcc406
Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/64a987a54c8f1500088b9a7d
Deploy Preview https://deploy-preview-451--conda-lock.netlify.app/flags
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

riccardoporreca commented 1 year ago

@maresb, I spotted also an instance of this in docs/flags.md

Linking here also https://github.com/conda/conda-lock/pull/448#issuecomment-1622219058, which mentions the same issue

maresb commented 1 year ago

Thanks a lot @riccardoporreca for the pointer, I really appreciate it. I had a long week, and I didn't really absorb your initial report.