search

conda / conda-lock

Lightweight lockfile for conda environments
https://conda.github.io/conda-lock/
Other
459 stars 102 forks source link

Include "fn" in fake_conda_environment for mamba>=1.4.6 compatibility #453

Closed riccardoporreca closed 1 year ago

riccardoporreca commented 1 year ago

Description

See #452. The initial goal of this (draft) PR is to provide evidence about the fact that including the file name ("fn") in the fake environment packages' JSON file makes mamba>=1.4.6 happy

netlify[bot] commented 1 year ago

Deploy Preview for conda-lock ready!

Name Link
Latest commit b2791b688e841f867b64b7d605849f6b1076e005
Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/64aada92ecfb120008f40bab
Deploy Preview https://deploy-preview-453--conda-lock.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

maresb commented 1 year ago

This looks good from my side. Before merging let's see if Jonas responds in #452.

riccardoporreca commented 1 year ago

@maresb, with the I am still keeping extract_json_object in update_specs_for_arch for consistency with solve_specs_for_arch. Publishing the PR

maresb commented 1 year ago

I am checking if this allows us to unpin Micromamba in the CI in #454 (before) and #455 (after).

maresb commented 1 year ago

Answer: I can unpin Micromamba independently, presumably thanks to using extract_json_object as in #448.