search

conda / conda-lock

Lightweight lockfile for conda environments
https://conda.github.io/conda-lock/
Other
457 stars 102 forks source link

Replace `suffix_union` with less general function #532

Closed jacksmith15 closed 8 months ago

jacksmith15 commented 8 months ago

Description

An alternative candidate to #531

This removes the quite complex suffix_union function with a more specific function for unifying channels when aggregating lock specifications, since that's the only place we use it.

If nothing else, this lets us document why we're doing it better since the function pertains specifically to merging packages sources.

Resolves #530

netlify[bot] commented 8 months ago

Deploy Preview for conda-lock ready!

Name Link
Latest commit 13c1e0301fb141b0b0403874c14a682c0d9cd9ba
Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/652d59fe02cc70000863f29c
Deploy Preview https://deploy-preview-532--conda-lock.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

maresb commented 8 months ago

We should also be able to remove __lt__ from Channel

maresb commented 8 months ago

Thanks so much @jacksmith15, I really appreciate all the effort here! I think this is a huge improvement.