search

conda / conda-lock

Lightweight lockfile for conda environments
https://conda.github.io/conda-lock/
Other
457 stars 102 forks source link

Fix platform validation for non-default names #535

Closed jacksmith15 closed 8 months ago

jacksmith15 commented 8 months ago

Description

https://github.com/conda/conda-lock/pull/499 added logic to support lockfiles with arbitrary names, by detecting the lockfile kind based on contents rather than name.

However it missed some logic for deciding whether to validate the platform, which still infers lock-file kind from the filename.

This leads to the following error when installing from a lock-file with non-default name:

RuntimeError: Cannot find platform in lockfile.

This can be worked around by passing --no-validate-platform, but is not the intended behaviour.

netlify[bot] commented 8 months ago

Deploy Preview for conda-lock ready!

Name Link
Latest commit 670fb6b37843c6a4148a7a30fac111a9e9994516
Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/6533bf970c0b1e0008c6081a
Deploy Preview https://deploy-preview-535--conda-lock.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

maresb commented 8 months ago

Thanks! Just cut a release for this.