search

conda / conda-lock

Lightweight lockfile for conda environments
https://conda.github.io/conda-lock/
Other
488 stars 103 forks source link

Make recent manylinux wheels findable by pypi_resolver #541

Closed lesteve closed 11 months ago

lesteve commented 11 months ago

Description

Fix #517. For now I have added 2 manylinux tags, for which manylinux provides a Docker image. I am guessing they are the most used manylinux wheels for recent wheels (i.e. more recent than manylinux2014, which is the same as manylinux_2_17).

Having said that other wheels likely exist in the wild, e.g. https://github.com/conda/conda-lock/issues/395 is a 2_27 wheel. An alternative would be to list all the possible versions between 2_17 and 2_28 (the latest Docker image provided by manylinux).

Note this could pose an issue if the glibc on the machine you are doing conda lock install does not have a recent enough glibc. As a data point, Ubuntu 18.04 (not supported any more) has glibc 2.27, Ubuntu 20.04 has glibc 2.31.

I have added a test as well using lightgbm and making sure that the resolved url points to a wheel that is more recent than (2, 17).

netlify[bot] commented 11 months ago

Deploy Preview for conda-lock ready!

Name Link
Latest commit 4ad59d64c9829d0d8c1a5dbc098da70f7718011a
Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/653ba1b4bdf51a00082be17d
Deploy Preview https://deploy-preview-541--conda-lock.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.