Closed basnijholt closed 7 months ago
Name | Link |
---|---|
Latest commit | 6ee68f168e8e067f4968afbcb980aea6d1d58fde |
Latest deploy log | https://app.netlify.com/sites/conda-lock/deploys/656a033e8e990c0008d2b5da |
Deploy Preview | https://deploy-preview-564--conda-lock.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Ah, took me a bit to figure out exactly what this is about. Here's my summary:
For the osx-arm64
platform, after filtering
- pip:
- psutil # [linux64]
becomes
- pip:
then we parse this like
yaml.safe_load("pip:") # {'pip': None}
so we must deal with the edge case mapping_spec["pip"] = None
and not just mapping_spec["pip"] = []
.
This looks great! Only thing is that this introduces an orphaned environment.yml
in the tests directory. Would you be able to write a test to check that your environment.yml
parses correctly and that psutil
is present only for linux64
?
And wow, UniDep looks awesome!!! It would be great if we could collaborate. Apart from getting fresh eyes on the codebase to clean up stuff like this, I really wish that conda-lock
could output more intermediate representations along the lines of your requirements.yaml
.
Thanks @basnijholt!!!
This came up in https://github.com/basnijholt/unidep/pull/23. This UniDep is a package that unifies Conda and Pip dependency specification and integrates with
conda-lock
. I think conda-lock folks might like it :smile:About this fix, it prevents:
Which occurs when locking:
Which becomes:
For
osx-arm64
.This fix skips
{"pip": None}
.