search

conda / conda-lock

Lightweight lockfile for conda environments
https://conda.github.io/conda-lock/
Other
456 stars 101 forks source link

Fix an issue when specifying full wheel URLs for a pypi package. #567

Closed romain-intel closed 6 months ago

romain-intel commented 6 months ago

The pypi solver expects hashes to be provided as part of the URL but, in most cases, if a user provides a URL for a package, they will not provide one with a hash. This PR ignores the missing hash instead of crashing.

A test was added that fails prior to this change and succeeds after.

netlify[bot] commented 6 months ago

Deploy Preview for conda-lock ready!

Name Link
Latest commit 6e49ef5197a96924f03c98db094f289956cf8b72
Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/65739ed66a308c000846f387
Deploy Preview https://deploy-preview-567--conda-lock.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

romain-intel commented 6 months ago

I am not sure why that one test failed. Feels like more of a fluke and unrelated to the PR.

maresb commented 6 months ago

I am not sure why that one test failed. Feels like more of a fluke and unrelated to the PR.

Indeed, I suspect that there's an out-of-memory condition or similar that occasionally causes a cascade of failures like that. Upon rerunning it's passing again.

romain-intel commented 6 months ago

Thanks for the super quick review. Accepted all changes.