search

conda / conda-lock

Lightweight lockfile for conda environments
https://conda.github.io/conda-lock/
Other
456 stars 101 forks source link

Replace unnecessary Popen with subprocess.run #582

Closed maresb closed 5 months ago

maresb commented 5 months ago

581 raised the issue of I/O deadlock with our use of subprocess.Popen and proposed solving this with threads. In this PR I take a step back and suggest that subprocess.Popen is unnecessary and can be replaced with subprocess.run. This simplifies the subprocess call and obviates the need for threads.

netlify[bot] commented 5 months ago

Deploy Preview for conda-lock ready!

Name Link
Latest commit 8ef256d9b0944bffa432f5e69253cf25ebc98978
Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/65a658fe346cce0008b081fa
Deploy Preview https://deploy-preview-582--conda-lock.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

maresb commented 5 months ago

Rejected in favor of #581