search

conda / conda-lock

Lightweight lockfile for conda environments
https://conda.github.io/conda-lock/
Other
456 stars 101 forks source link

Add explanation and minor improvement to #581 #586

Closed tadeu closed 4 months ago

tadeu commented 5 months ago

Description

Adding an explanation and a suggested improvement to #581 - it seems important to make it explicit why the thread is there.

netlify[bot] commented 5 months ago

Deploy Preview for conda-lock ready!

Name Link
Latest commit 3a9f3c37643fe14888109cca6e3c19d15057fa10
Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/65a99228aaab3a00082d44d9
Deploy Preview https://deploy-preview-586--conda-lock.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tadeu commented 5 months ago

Sorry for not doing this together with the original PR before :blush:

maresb commented 5 months ago

Thanks a lot for the comment, I find it very helpful.

Does this use of stdout_thread make any functional difference? Like if p.stdout is true once is it always true?

tadeu commented 5 months ago

Does this use of stdout_thread make any functional difference? Like if p.stdout is true once is it always true?

No functional difference, just maintainability: in case the code is refactored and if p.stdout: is changed to something different, the other if p.stdout: would also need to be changed (and it's a bit far away) - now there's no way to change one condition and "forget" to change the other one.