search

conda / conda-lock

Lightweight lockfile for conda environments
https://conda.github.io/conda-lock/
Other
456 stars 101 forks source link

Increase minimum ensureconda version for py3.12 compatibility #597

Closed jfrost-mo closed 4 months ago

jfrost-mo commented 4 months ago

Prior to ensureconda v1.4.4 distutils is used, which was removed in python 3.12. This prevents conda-lock running under python newer than 3.11, so the minimum version of ensureconda is increased.

Fixes https://github.com/conda/conda-lock/issues/542 Fixes https://github.com/conda/conda-lock/issues/596

The fix involves switching from distutils.version to packaging.version from the packaging package, which is maintained by the pypa.

The conda-lock.yml files will need regenerating after this PR.

netlify[bot] commented 4 months ago

Deploy Preview for conda-lock ready!

Name Link
Latest commit b86ec4361e1cef676b3caaa4fcaaa056751bdd22
Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/65c0e2020c87a7000807a892
Deploy Preview https://deploy-preview-597--conda-lock.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

maresb commented 4 months ago

Thanks @jfrost-mo! Feel free to ping me if it's green and not merged.

maresb commented 4 months ago

Just pushed a fix for #596

jfrost-mo commented 4 months ago

I was too slow with https://github.com/conda/conda-lock/pull/598 then. You probably want to add packaging as an explicit dependency to the pyproject.toml now its directly used. I'll go ahead and do that.

maresb commented 4 months ago

No, it's already there, thanks though!

maresb commented 4 months ago

https://github.com/conda/conda-lock/blob/2c2999bb9805dbc4abe46e38f7d70d038728b31c/pyproject.toml#L57

jfrost-mo commented 4 months ago

Oops, I'll revert my change then.

jfrost-mo commented 4 months ago

@maresb CI is all passing now.