conda / conda-lock

Lightweight lockfile for conda environments
https://conda.github.io/conda-lock/
Other
456 stars 101 forks source link

[WIP] Update to poetry 1.8.2 (minimal changes) #636

Closed romain-intel closed 1 month ago

romain-intel commented 1 month ago

Description

This addresses #613 and updates Poetry to a more modern release (in particular taking in changes around support for Metadata from pypi indices).

This is still a WIP, still missing:

netlify[bot] commented 1 month ago

Deploy Preview for conda-lock ready!

Name Link
Latest commit 4fa0e1ecb144900213b5eee071e73edd9d38047d
Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/6639df87e2a8e30008c82e14
Deploy Preview https://deploy-preview-636--conda-lock.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

maresb commented 1 month ago

Thanks a lot for this!!! Did you use the vendoring tool? If so, are you leaving the source code inside the conda_lock/_vendor directory untouched?

When you're ready for more serious review, would it be possible to put vendoring sync in its own commit?

romain-intel commented 1 month ago

I did use vendoring sync. I ran it and fixed up the issues in the other files (the API changes a bit). I think there was one change after the vendoring tool. I'll update the patch to fix it up (it was just hardcoding a version value). But otherwise yes, there is no other change than the ones made by the vendoring tool.

Are you saying you just want the broken commit (ie: it won't work) separately from the fixes so that it is easier to review just the "changes"?

maresb commented 1 month ago

Are you saying you just want the broken commit (ie: it won't work) separately from the fixes so that it is easier to review just the "changes"?

Exactly, that would be excellent! Probably a more direct way to phrase it is that I'd like a single commit that runs vendoring sync with absolutely no other changes. Please feel free to use git commit --no-verify. That should make it significantly easier for me to review. Thanks!!!

romain-intel commented 1 month ago

Closed in favor of #637 which refactors the commits.

maresb commented 1 month ago

Looks like this wasn't actually closed, but that seems to have been your intention based on the last comment. (I'll leave it to you.)