search

conda / conda-lock

Lightweight lockfile for conda environments
https://conda.github.io/conda-lock/
Other
456 stars 101 forks source link

Replace logger.warn w/ logger.warning #646

Closed zklaus closed 2 weeks ago

zklaus commented 2 weeks ago

Description

This replaces calls to logger.warn with logger.warning. The former has been deprecated since Python 3.3 and generates DeprecationWarnings that can make output particularly in debugging and testing more noisy than necessary.

Also see conda/conda#13963.

netlify[bot] commented 2 weeks ago

Deploy Preview for conda-lock ready!

Name Link
Latest commit b0a50b17f8e980e7390dbc49b2a6a7ee3f66787c
Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/6668357fde39280008ce83e0
Deploy Preview https://deploy-preview-646--conda-lock.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

maresb commented 2 weeks ago

Thanks @zklaus!

Most of the changes are on vendored code, so that should not be changed outside of revendoring or specific patches.

The changes to conda_lock/conda_solver.py look good though! Would you be able to rebase with just this? Thanks!

zklaus commented 2 weeks ago

Thanks for the quick feedback, @maresb! I did put those changes into a separate commit because I expected this discussion :) The changes in vendored code are all in conda. The corresponding PR for conda is conda/conda#13963.

What's the procedure for revendoring here?

maresb commented 2 weeks ago

Roughly the procedure is

  1. Install vendoring
  2. Update vendor.txt to update the version
  3. Run vendoring update
  4. Fix breakage

Now may actually be a good time to revendor since we can do it concurrently with https://github.com/conda/conda-lock/pull/637. Thanks for your interest in this @zklaus!

zklaus commented 2 weeks ago

Hm. If we are doing this, it may be best to wait for a release of conda that includes the fixes, so how about this:

  1. I'll remove the changes to the vendored code here
  2. We merge this PR and consider it enough to unblock conda/conda#13963
  3. We merge conda/conda#13963
  4. Wait for the next conda release
  5. Revendor to that version
  6. Profit
maresb commented 2 weeks ago

perfect, thanks @zklaus!!!