conda / conda-lock

Lightweight lockfile for conda environments
https://conda.github.io/conda-lock/
Other
457 stars 102 forks source link

take into account branch, tag or rev on git dependencies #655

Open sebhmg opened 6 days ago

sebhmg commented 6 days ago

Problem

conda-lock does not take into account rev, branch or tag for a git dependency in pyprojet.toml See reference in Poetry documentation about specifying the git revision: https://python-poetry.org/docs/dependency-specification/#git-dependencies

It only considers the revision when expressed in the url as url@rev

Fix

Checks both the url and the branch, tag or rev field. Raises an exception in case the information is specified both ways with different values.

netlify[bot] commented 6 days ago

Deploy Preview for conda-lock ready!

Name Link
Latest commit 3d1a62e55b219765da74a3b297b37f3bf8d45333
Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/667f87d931a476000866e3d9
Deploy Preview https://deploy-preview-655--conda-lock.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

maresb commented 5 days ago

Thanks @sebhmg!

Would you be able to add some tests? You could add them to this pyproject.toml and update this test accordingly,