conda / conda-pack

Package conda environments for redistribution
https://conda.github.io/conda-pack/
BSD 3-Clause "New" or "Revised" License
528 stars 93 forks source link

Add the deploy step for gh pages #377

Closed ericdill closed 2 weeks ago

ericdill commented 2 weeks ago

Description

follow up from #376

you'll need to make some changes on the settings pages

image

then, a multi-step change is needed: step 1: image step 2: image

Once the above things have been set, the docs should push on any tag that gets pushed to this repo.

jezdez commented 2 weeks ago

pre-commit.ci autofix

ericdill commented 2 weeks ago

@jezdez fixed the linter issue

xhochy commented 2 weeks ago

@jezdez You need to change the environments setting. I cannot do that.

dbast commented 2 weeks ago

The current settings:

image

Looks correct to be and ready to merge.

dbast commented 2 weeks ago

failed https://github.com/conda/conda-pack/actions/runs/11853502765/job/33034332675

xhochy commented 2 weeks ago

Probably https://github.com/conda/conda-pack/actions/runs/11853502765/workflow#L154 also needs to be patched.

dbast commented 2 weeks ago

The error is: Error: No artifacts named "github-pages" were found for this workflow run. Ensure artifacts are uploaded with actions/upload-artifact@v4 or later.

Both actions:

list the default for artifact_name to be github-pages and we do not overwrite that.

The issue is: https://github.com/conda/conda-pack/actions/runs/11853502765/workflow#L152 ... upload happens only when tagged.

xhochy commented 2 weeks ago

We also need to allow tags for the environment:

image
jezdez commented 2 weeks ago

@jezdez You need to change the environments setting. I cannot do that.

Can you try again?

xhochy commented 2 weeks ago

I did rerun the job https://github.com/conda/conda-pack/actions/runs/11859545372/job/33061200057 and it keeps failing

jezdez commented 2 weeks ago

@xhochy I've fixed the environment protection rule to allow tags as well as the main branch, and now reran the whole steps (since the docs artifact has been been invalidated): https://github.com/conda/conda-pack/actions/runs/11859545372