conda / conda-package-handling

Create and extract conda packages of various formats
https://conda.github.io/conda-package-handling/
BSD 3-Clause "New" or "Revised" License
26 stars 37 forks source link

Add `assert packages match` function to replace odd old API #203

Closed dholth closed 5 months ago

dholth commented 1 year ago

Checklist

What is the idea?

We have a validate_converted_files_match_streaming function in validate.py with a weird interface "returns details about mismatched files", that exists only to support the existing transmute CLI function.

There is no reason to convert a .conda to .tar.bz2 and then need details about which files did not convert correctly. Instead, an exception should be raised an the faulty file should be deleted. The assertion-style interface will be easier to use compared to checking that the list of differences is empty.

github-actions[bot] commented 6 months ago

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    • What OS and version you reproduced the issue on
    • What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!