conda / conda-package-streaming

An efficient library to read from new and old format .conda and .tar.bz2 conda packages.
https://conda.github.io/conda-package-streaming/
Other
10 stars 9 forks source link

Tests require conda, note that #52

Closed opoplawski closed 1 year ago

opoplawski commented 1 year ago

Description

While packaging this for Fedora (https://bugzilla.redhat.com/show_bug.cgi?id=2150574) we've noted that the tests seem to require conda.

An alternative I suppose would be for https://github.com/conda/conda-package-streaming/blob/9c5dba578f0a2fe47f52ac02218483763a720744/tests/server.py#L24 to handle CONDA_EXE not being set more gracefully and skipping the tests that require it.

Also, is boto3-stubs[essential] really required?

dholth commented 1 year ago

Thanks. The tests used to require conda-build since this used to be part of conda-build, which would pull in conda. We tend to have it installed. But you'll have to run the tests in a conda environment since conda is not a pypi package.

It uses conda to find test packages. It would probably be better to download or include a fixed set of test packages.

The boto3 stubs are required for development, but we don't have a separate [dev] extra for them.

Oh, and we are moving to make requests optional (not a declared dependency) since you can use the core library without using requests. The conda packaging in meta.yaml is this way.

opoplawski commented 1 year ago

It would be really nice not to have a dep on conda but instead have a set of test packages to avoid circular deps. In particular Fedora builders do not have network access so everything needs to be provided via the source tarballs.

Thanks for the info.