pkg installer: Fix ownership of files installed into $HOME - Githubissues

conda / constructor

tool for creating installers from conda packages

https://conda.github.io/constructor/

Other

452 stars 166 forks source link

pkg installer: Fix ownership of files installed into $HOME #784

Closed marcoesters closed 2 months ago

marcoesters commented 2 months ago

Description

When installing outside $HOME, the pkg installer installs as root. Constructor changes the ownership of the $PREFIX directory to $USER: https://github.com/conda/constructor/blob/58385ee6d58a2228ddbf8b40f2fe179a3e77b5ab/constructor/osx/run_installation.sh#L115

However, the installer creates additional files and directories outside of $PREFIX:

${HOME}/.conda
All files and directories created by conda init, e.g., ${HOME}/.bash_profile or ${HOME}/.config/powershell

This PR fixes the ownership of those files and directories as well.

Checklist - did you ...

[X] Add a file to the news directory (using the template) for the next release's release notes?
[X] Add / update necessary tests?
[X] Add / update outdated documentation?

jaimergp commented 2 months ago

Let's double check SH vs BASH vs POSIX for that nice chunk of shell code :)