Windows CLI installer `/D` only works in silent mode (`/S`) - Githubissues

conda / constructor

tool for creating installers from conda packages

https://conda.github.io/constructor/

Other

457 stars 168 forks source link

Windows CLI installer `/D` only works in silent mode (`/S`) #813

Open pavelzw opened 3 months ago

pavelzw commented 3 months ago

Checklist

[X] I added a descriptive title
[X] I searched open reports and couldn't find a duplicate

What happened?

When running a generated windows installer with /D, the directory doesn't get passed through when not using silent mode.

.\python-example-1.0.0-Windows-x86_64.exe /D=C:\example-python

The GUI still displays C:\ProgramData\python-example as path. When using silent mode, it works.

I am using conda-constructor in an isolated environment via pixi global install constructor.

Conda Info

No response

Conda Config

No response

Conda list

No response

Additional Context

No response

marcoesters commented 3 months ago

I think it's because of these lines: https://github.com/conda/constructor/blob/main/constructor/nsis/main.nsi.tmpl#L430-L454

I'm wondering if this is even necessary because the default is set in another instance: https://github.com/conda/constructor/blob/main/constructor/nsis/main.nsi.tmpl#L614-L622

It would require some testing to see if this is obsolete. Is this behavior breaking anything? I understand that this is a nuisance though.