search

conda / grayskull

Grayskull :skull: - Recipe generator for Conda
https://conda.github.io/grayskull/
Apache License 2.0
320 stars 68 forks source link

Is '--no-deps --no-build-isolation' needed for Python given conda-build defaults? #583

Closed matthewfeickert closed 3 hours ago

matthewfeickert commented 3 hours ago

In PR https://github.com/conda/grayskull/pull/480 the use of --no-deps --no-build-isolation was introduced as defaults for Python pip installs

https://github.com/conda/grayskull/blob/9d5d5e2420ff5468fa3b660d79d971ac41243d23/grayskull/strategy/pypi.py#L66

(now at

https://github.com/conda/grayskull/blob/5b293078ea4fb17572dfa63ee1dde8612d884f00/grayskull/strategy/pypi.py#L67 )

However, as @henryiii points out in https://github.com/conda-forge/packaging-feedstock/pull/32#discussion_r1844918884, conda-build already sets these defaults

...
    env["PIP_NO_BUILD_ISOLATION"] = "False"
    # some other env vars to have pip ignore dependencies.
    # we supply them ourselves instead.
    env["PIP_NO_DEPENDENCIES"] = True
    env["PIP_IGNORE_INSTALLED"] = True
...

Is there any reason to have these (good options for conda package builds) duplicated here so that they appear explicitly in conda package repiece meta.yaml files?

matthewfeickert commented 3 hours ago

Got beaten out by Henry as he opened Issue #582 just ahead of me, so closing as duplicate of that.